Skip to content

Commit

Permalink
(hw-results/tabular) add excludes on orphaned exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
bensimner committed May 20, 2024
1 parent 247d4c4 commit 178c9a4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
1 change: 1 addition & 0 deletions hw-results/exclude-exceptions.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
LB+R-svc-W+R-svc-W MP+W-svc-W+addr MP+W-svc-eret-W+addr MP+dmb+R-svc-R MP+dmb+R-svc-eret-R MP+dmb+svc-R-eret-R MP+dmb+svc-R-eret-svc-R MP+dmb+svc-R-svc-R MP+dmb+svc-R-svc-eret-R MP+dmb+svc2-R-eret-R MP+svc-W-eret-W+addr SB+W-svc-R+W-svc-R SB+svc-W-eret-R+svc-W-eret-R SB+svc-W-svc-eret-R+svc-W-svc-eret-R SB+svc2-W-eret-R+svc2-W-eret-R
17 changes: 10 additions & 7 deletions hw-results/tabular.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
[--macros]
[--macros-file MACROS_FILE]
[--file FILE | --device DEVICE]
[--devices DEVICES]
[--excludes EXCLUDES] [--includes INCLUDES]
options:
Expand All @@ -20,7 +21,8 @@
--macros-file MACROS_FILE
--herdtools
--file FILE, -f FILE
--device DEVICE, -d DEVICE
--device DEVICE[ DEVICE DEVICE], -d DEVICE
--devices DEVICE DEVICE DEVICE
--excludes EXCLUDES Comma-separated list of excluded groups, e.g. --excludes=@grp1,@grp2
--includes INCLUDES Comma-separated list of included groups, e.g. --includes=@grp1,@grp2
Expand Down Expand Up @@ -61,16 +63,17 @@

group = parser.add_mutually_exclusive_group()
group.add_argument("--file", "-f", action="append")
group.add_argument("--device", "-d", action="append", type=pathlib.Path)
group.add_argument("--devices", nargs="+", type=pathlib.Path, default=())
group.add_argument("--device", "-d", dest="devices", nargs="+", type=pathlib.Path)

parser.add_argument(
"--excludes",
action='append',
nargs="+",
help="Comma-separated list of excluded groups, e.g. --excludes=@grp1,@grp2",
)
parser.add_argument(
"--includes",
action='append',
nargs="+",
help="Comma-separated list of included groups, e.g. --includes=@grp1,@grp2",
)

Expand Down Expand Up @@ -443,7 +446,7 @@ def filter_devices(grp_list, devices: "Mapping[Device, List[LogFileResult]]", in

if (includes and not any(g in includes for g in groups)) or (
any(g in excludes for g in groups)
):
) or test_name in excludes:
if print_skips:
print("Skip ! {}".format(test_name))

Expand Down Expand Up @@ -817,8 +820,8 @@ def main(args):
excludes = [e for e in excludes if e]

devices = {}
if args.device:
for device_dir_path in args.device:
if args.devices:
for device_dir_path in args.devices:
if not device_dir_path.is_dir():
raise ValueError(
"-d accepts directories not files: {}".format(device_dir_path)
Expand Down

0 comments on commit 178c9a4

Please sign in to comment.