Update CSS match regex to avoid mangling anchor URL's in CSS#186
Open
matthewmoto wants to merge 1 commit intoremy:masterfrom
Open
Update CSS match regex to avoid mangling anchor URL's in CSS#186matthewmoto wants to merge 1 commit intoremy:masterfrom
matthewmoto wants to merge 1 commit intoremy:masterfrom
Conversation
…atterns) for things like PrinceXML page numbering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the issue I opened: #185
Basically, it doesn't touch CSS URL's that start with a "#" character so things like same-page anchor targets are left alone.