Fix the trampoline functions of recurring labeled alternatives #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These trampoline functions are normally only used in mutation scenarios when a subtree of a labeled alternative is re-generated by calling the function named as the labeled alternative. If the label is recurring, this function is an artificial trampoline that calls one of the functions that have the same name prefix but differ in a numbered suffix (e.g., `rule_Label` calls `rule_Label_1` or `rule_Label_2`). The trampoline function is expected to be transparent, i.e., to create a tree structure as if one of the number-suffixed functions was called. However, until now, the tree structures created by the trampolines and the way the trees were created were incorrect. The trampoline created two extra nodes in the tree: one UnparserRule node named as the labeled alternative (e.g., `rule_Lable`) and one UnparserRuleAlternative node. - Issue 1: Both nodes are superfluous in the end result. - Issue 2: Both nodes are necessary to help the decision model choose between the number-suffixed functions. But then, the UnparserRule should be named as the main rule that contains the labeled alternatives (e.g., `rule`). This commit fixes both issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These trampoline functions are normally only used in mutation scenarios when a subtree of a labeled alternative is re-generated by calling the function named as the labeled alternative. If the label is recurring, this function is an artificial trampoline that calls one of the functions that have the same name prefix but differ in a numbered suffix (e.g.,
rule_Labelcallsrule_Label_1orrule_Label_2). The trampoline function is expected to be transparent, i.e., to create a tree structure as if one of the number-suffixed functions was called.However, until now, the tree structures created by the trampolines and the way the trees were created were incorrect. The trampoline created two extra nodes in the tree: one UnparserRule node named as the labeled alternative (e.g.,
rule_Lable) and one UnparserRuleAlternative node.rule).This commit fixes both issues.