Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the formating of (Parent)Rules #270

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

akosthekiss
Copy link
Collaborator

  • Vertically compact the repr format of ParentRules with children

  • Avoid empty lines in the dbg format of ParentRules with no children

  • Don't show None as the name in the repr format of UnparserRuleQuantifieds

  • Implement reusable computations of repr and dbg formats of children of ParentRules

  • Use f-strings instead of .format() where possible

- Vertically compact the repr format of ParentRules with children
- Avoid empty lines in the dbg format of ParentRules with no
  children
- Don't show None as the name in the repr format of
  UnparserRuleQuantifieds

- Implement reusable computations of repr and dbg formats of
  children of ParentRules
- Use f-strings instead of .format() where possible
@coveralls
Copy link

Coverage Status

coverage: 83.751% (-0.5%) from 84.273%
when pulling 16099ab on akosthekiss:impr-format
into 8c81d4f on renatahodovan:master.

Copy link
Owner

@renatahodovan renatahodovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@renatahodovan renatahodovan merged commit 294f927 into renatahodovan:master Jan 26, 2025
26 checks passed
@akosthekiss akosthekiss deleted the impr-format branch January 26, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants