check for skipped request parameters #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YasinAshorian
approved these changes
Oct 30, 2022
michelmelo
added a commit
to michelmelo/laravel-page-speed
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for skipped parameter request
Motivation and context
I had a challenge on Google AMP pages when parameter defer is added to scripts, which results to AMP error. I tried to add parameters on skip like '?amp=1','?amp=1','?amp' where neither would work.
How has this been tested?
I have tested on a news site https://www.standardmedia.co.ke/entertainment/fashion-and-style/2001409537/best-dressed-at-the-bafta-awards-2021 where when parameter amp is set it escapes laravel pagespeed.