workers: handshake-manager: internal_engine: check that orders are in the same matching pool #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
force-pushed
the
andrew/order-assignment
branch
from
d5e9af9
to
f2f5560
Compare
akirillo
force-pushed
the
andrew/matching-engine-pool-check
branch
from
9958a18
to
5a0eb69
Compare
joeykraut
reviewed
Jul 2, 2024
akirillo
force-pushed
the
andrew/order-assignment
branch
2 times, most recently
from
17648ed
to
6d9464b
Compare
akirillo
force-pushed
the
andrew/matching-engine-pool-check
branch
2 times, most recently
from
82cdcf0
to
b94d909
Compare
… the same matching pool
akirillo
force-pushed
the
andrew/matching-engine-pool-check
branch
from
199b922
to
e424cb1
Compare
joeykraut
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal matching engine to check that local orders which are candidates for a match are in the same matching pool. For now, we only add this check the internal matching engine.
I tested this ad-hoc by running a local relayer, putting up 2 crossing orders via the CLI, and ensuring that they matched & settled successfully.
Testing that orders not in the same matching pool do not match is deferred for when the admin API endpoint for creating orders in different matching pools is implemented.