-
-
Notifications
You must be signed in to change notification settings - Fork 9
[Snyk] Upgrade puppeteer-cluster from 0.23.0 to 0.25.0 #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||
| "express": "^4.17.2", | ||||||
| "express-healthcheck": "^0.1.0", | ||||||
| "puppeteer": "^5.5.0", | ||||||
| "puppeteer-cluster": "^0.23.0", | ||||||
| "puppeteer-cluster": "^0.25.0", | ||||||
|
||||||
| "puppeteer-cluster": "^0.25.0", | |
| "puppeteer-cluster": "^0.23.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to
puppeteer-cluster@0.25.0is incompatible with thepuppeteerversion (^5.5.0) currently in use. As stated in the release notes and itspeerDependencies,puppeteer-cluster@0.25.0requirespuppeteer@>=22.0.0.To resolve this incompatibility, the
puppeteerdependency must also be upgraded.Important Note: Upgrading
puppeteerfrom version 5 to a much later version will require code changes due to breaking API changes. For example, the private APIpage._clientused inserver.js:217is no longer available in recentpuppeteerversions and should be replaced with the publicpage.cookies()method. Please carefully review thepuppeteerchangelogs for other breaking changes and update your code accordingly.