-
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade puppeteer-cluster from 0.23.0 to 0.25.0 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade puppeteer-cluster from 0.23.0 to 0.25.0. See this package in npm: puppeteer-cluster See this project in Snyk: https://app.snyk.io/org/rennokki/project/c62dae3a-7c7b-46df-a181-e3278169b559?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @rennokki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades puppeteer-cluster from version 0.23.0 to 0.25.0. While keeping dependencies up-to-date is good practice, this upgrade introduces a critical breaking change. The new version of puppeteer-cluster requires puppeteer version 24.0.0 or newer, but the project is still on puppeteer version ^5.5.0. This incompatibility must be resolved by also upgrading the puppeteer dependency to prevent the application from breaking.
| "express-healthcheck": "^0.1.0", | ||
| "puppeteer": "^5.5.0", | ||
| "puppeteer-cluster": "^0.23.0", | ||
| "puppeteer-cluster": "^0.25.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to [email protected] is incompatible with the currently used version of puppeteer. As stated in the release notes, [email protected] requires puppeteer@>=24.0.0. Your package.json specifies puppeteer: "^5.5.0". This version mismatch will cause your application to fail. To fix this, you must also upgrade the puppeteer dependency. For example:
"puppeteer": "^24.0.0",
"puppeteer-cluster": "^0.25.0",Please update the puppeteer version accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the puppeteer-cluster dependency from version 0.23.0 to 0.25.0, which includes bug fixes, updated TypeScript types, and improved error handling when the cluster is closed.
Key Changes:
- Updates puppeteer-cluster to version 0.25.0, which includes fixes for cluster retry issues and updated dependencies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "express-healthcheck": "^0.1.0", | ||
| "puppeteer": "^5.5.0", | ||
| "puppeteer-cluster": "^0.23.0", | ||
| "puppeteer-cluster": "^0.25.0", |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to puppeteer-cluster 0.25.0 will cause compatibility issues with the current puppeteer version. According to the puppeteer-cluster release notes, version 0.25.0 requires puppeteer version 24.0.0 or newer. However, this project is using puppeteer version 5.5.0. Either upgrade puppeteer to version 24.0.0 or newer, or downgrade puppeteer-cluster to version 0.23.0.
| "puppeteer-cluster": "^0.25.0", | |
| "puppeteer-cluster": "^0.23.0", |
Snyk has created this PR to upgrade puppeteer-cluster from 0.23.0 to 0.25.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released 2 months ago.
Release notes
Package name: puppeteer-cluster
-
0.25.0 - 2025-11-13
- Updated puppeteer types to version 24
- Updated dependencies to their latest versions
- Exported more types for improved TypeScript use
- Cluster retrying in error cases when it was already closed
-
0.24.0 - 2024-03-17
- Updated all dependencies to their latest versions
- Added a missing timeout case when closing the browser
- Removed
- Dropped support (in tests) for Node.js <=16 as puppeteer also support for these versions
- Fixed breaking puppeteer changes introduced in version 22 (renamed
-
0.23.0 - 2022-01-23
- Updated dependencies which haven't been updated for more than one year
- Moved from Travis to Github Actions
- Remove the linter for now, but will probably add it back later after having a look at the pull requests.
- Fixed bug #395 not using
from puppeteer-cluster GitHub release notesNote: Use a version older than
0.25.0if you want to use a puppeteer version older than 24.0.0.Changed
Fixed
Note: Use a version older than
0.24.0if you want to use a puppeteer version older than 22.0.0.Changed
package-lock.jsonas otherwise yarn complains (warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.).Fixed
createIncognitoBrowserContexttocreateBrowserContext)Changed
Fixed
perBrowserOptionsImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: