-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipenv): Use @renovatebot/detect-tools
for constraints detection
#29787
feat(pipenv): Use @renovatebot/detect-tools
for constraints detection
#29787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new code looks promising, please also let me review changes to the detect tools. I need them later for containerbase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (is.nonEmptyString(pipfile.requires?.python_version)) { |
this should be replaced too
@renovatebot/detect-tools
for constraints detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
583c6a1
to
af430ce
Compare
# Conflicts: # lib/modules/manager/pipenv/artifacts.ts
🎉 This issue has been resolved in version 38.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Use drop-in library replacement for pypi constraint detection.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: