Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(git): prepare support for commit signing with other key formats #29875

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Jun 26, 2024

Changes

I've refactored the implementation for commit signing as a preparatory step for supporting other key formats like SSH.

Context

I submitted a PR (#29550) that adds support for SSH-based commit signing which currently includes a refactoring to support multiple key formats. During review, it was suggested to do the refactoring in a separate PR (#29550 (comment)).

Once this PR has been merged, I'll update #29550 accordingly.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice June 29, 2024 08:43
@rarkins rarkins added this pull request to the merge queue Jun 29, 2024
Merged via the queue into renovatebot:main with commit 84ca13a Jun 29, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.421.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sisp sisp deleted the refactor/gpg-commit-signing branch June 30, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants