feat(manager/rust-toolchain): Add support for rust toolchain versioning #32432
+591
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-leonhard
changed the title
rarkins
requested changes
Nov 11, 2024
Co-authored-by: Rhys Arkins <[email protected]>
rarkins
reviewed
Nov 11, 2024
rarkins
requested changes
Nov 12, 2024
Co-authored-by: Rhys Arkins <[email protected]>
kyle-leonhard
changed the title
|
Hey @rarkins , thanks for bearing with me as I figured things out. I appreciate it. I think things are in a good place now. Do you mind triggering the workflows once more and giving things a look? Is there a good way to try this out locally before merging, beyond unit tests? I'm betting on the renovate CLI |
|
If you mean test out your own (new) functionality then you can run |
viceice
reviewed
Nov 19, 2024
| describe('modules/manager/rust-toolchain/extract', () => { | ||
| describe('extractPackageFile()', () => { | ||
| it('returns result when fully qualified version is set', () => { | ||
| const res = extractPackageFile(` |
There was a problem hiding this comment.
use codeBlock template helper for proper indention
|
|
||
| export function extractPackageFile(content: string): PackageFileContent { | ||
| const deps: PackageDependency[] = []; | ||
| for (const match of regexMatchAll(channelRegex, content)) { |
There was a problem hiding this comment.
theres only one occurrence, so need of match all
I would prefer to use our toml parser and zod schema validation. so we don't have false deps when they extend the format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new manager that manages Rust toolchain versions in
rust-toolchain.tomlfiles based on releases in the rust-lang/rust github repository. The relevant Rust docs are here: https://rust-lang.github.io/rustup/overrides.htmlContext
Renovate supports updating Cargo crates but not the Rust toolchain itself. This has been discussed here, for example: #24762.
Rust allows for the toolchain version (e.g. 1.82.0) to be specified as an override in the
channelkey in arust-toolchain.tomlfile (docs). The version may be specified either as a fully qualified version (e.g. 1.82.0) a major.minor version (e.g. 1.82) or as a named release (e.g. beta, nightly, stable, nightly-2014-11-15). This PR ignores named releases.https://github.com/rust-lang/rust releases are the datasource.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: