Skip to content

Conversation

@setchy
Copy link
Collaborator

@setchy setchy commented Jun 4, 2025

Changes

Add new replacement preset to help with @tsconfig/bases node updates, both within package.json and tsconfig.json

Demo repository: https://github.com/setchy/renovate-tsconfig-bases

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy
Copy link
Collaborator Author

setchy commented Jun 4, 2025

The build began failing once I added the corresponding customManager to help keep the tsconfig.json file in-sync with the replacement updates.

Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this start a cascading series of replacements? e.g. 10 -> 12 -> 14 -> 16 -> 18 etc.

@setchy
Copy link
Collaborator Author

setchy commented Jun 4, 2025

Won't this start a cascading series of replacements? e.g. 10 -> 12 -> 14 -> 16 -> 18 etc.

It would, but I figured users could decide if they applied the replacement, declined it, or left it open.

It would be nice if it could be kept in sync with the repositories node version - or: have these replacements dependant on another dependency version

@rarkins rarkins added the auto:inactive-pr PR has become inactive and we want to prompt the submitter label Aug 16, 2025
@github-actions
Copy link
Contributor

Hi there,

This PR appears to have been inactive for a while. Please let us know if you are still working on it, or if we can close it for now.

Thanks, the Renovate team

@setchy
Copy link
Collaborator Author

setchy commented Dec 2, 2025

I would still like to find a solution to help automate the @tsconfig/bases updates.

Open to other suggestions on ways to implement this. Are there other packages that follow a similar need?

@setchy setchy changed the title feat: @tsconfig/bases node replacements feat(presets): @tsconfig/bases node replacements Dec 2, 2025
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we need the replacements? Won't the custom manager alone be enough

@setchy
Copy link
Collaborator Author

setchy commented Dec 8, 2025

Why would we need the replacements? Won't the custom manager alone be enough

It's been a while since I looked into this, but to my knowledge the replacements were needed as the depName itself changes

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@setchy setchy requested a review from viceice December 9, 2025 22:00
Signed-off-by: Adam Setch <[email protected]>
@setchy
Copy link
Collaborator Author

setchy commented Dec 11, 2025

@viceice - does this now make sense, splitting the logic between a set of replacements, and then a customManager for keeping the tsconfig extends updated

viceice
viceice previously approved these changes Dec 11, 2025
@viceice viceice requested a review from secustor December 11, 2025 20:48
Copy link
Member

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else LGTM

@setchy setchy requested review from secustor and viceice December 12, 2025 18:56
@secustor secustor enabled auto-merge December 12, 2025 19:07
@secustor secustor added this pull request to the merge queue Dec 12, 2025
Merged via the queue into renovatebot:main with commit 93bd678 Dec 12, 2025
41 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 42.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member

viceice commented Dec 13, 2025

@setchy it seems something is wrong

Progress: resolved 1, reused 0, downloaded 0, added 0
 ERR_PNPM_NO_MATCHING_VERSION  No matching version found for @tsconfig/[email protected] while fetching it from https://npm.xxx.test/

This error happened while installing a direct dependency of /tmp/renovate/repos/forgejo/org/infra

The latest release of @tsconfig/node20 is "20.1.8". Published at 11/18/2025

If you need the full list of all 12 published versions run "$ pnpm view @tsconfig/node20 versions".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto:inactive-pr PR has become inactive and we want to prompt the submitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants