-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(presets): @tsconfig/bases node replacements
#36308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presets): @tsconfig/bases node replacements
#36308
Conversation
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
|
The build began failing once I added the corresponding |
rarkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this start a cascading series of replacements? e.g. 10 -> 12 -> 14 -> 16 -> 18 etc.
It would, but I figured users could decide if they applied the replacement, declined it, or left it open. It would be nice if it could be kept in sync with the repositories node version - or: have these replacements dependant on another dependency version |
|
Hi there, This PR appears to have been inactive for a while. Please let us know if you are still working on it, or if we can close it for now. Thanks, the Renovate team |
|
I would still like to find a solution to help automate the Open to other suggestions on ways to implement this. Are there other packages that follow a similar need? |
@tsconfig/bases node replacements
RahulGautamSingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need the replacements? Won't the custom manager alone be enough
Signed-off-by: Adam Setch <[email protected]>
It's been a while since I looked into this, but to my knowledge the replacements were needed as the |
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
…b.com/setchy/renovate into feat/replacements-tsconfig-node-bases
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
|
@viceice - does this now make sense, splitting the logic between a set of replacements, and then a customManager for keeping the tsconfig extends updated |
secustor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else LGTM
Co-authored-by: Sebastian Poxhofer <[email protected]>
|
🎉 This PR is included in version 42.52.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@setchy it seems something is wrong |
Changes
Add new replacement preset to help with @tsconfig/bases node updates, both within
package.jsonandtsconfig.jsonDemo repository: https://github.com/setchy/renovate-tsconfig-bases
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: