Skip to content

feat(custom): support tsconfig/node in extends array #40030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viceice merged 1 commit into from
Dec 17, 2025
Merged

feat(custom): support tsconfig/node in extends array #40030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion lib/config/presets/internal/custom-managers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ describe('config/presets/internal/custom-managers', () => {
describe('Update `tsconfig/node` version in tsconfig.json', () => {
const customManager = presets.tsconfigNodeVersions.customManagers?.[0];

it(`find dependencies in file`, async () => {
it(`find in tsconfig.json extends string`, async () => {
const fileContent = codeBlock`
{
"extends": "@tsconfig/node20/tsconfig.json",
Expand All @@ -833,6 +833,33 @@ describe('config/presets/internal/custom-managers', () => {
]);
});

it(`find in tsconfig.json extends array`, async () => {
const fileContent = codeBlock`
{
"extends": [
"@tsconfig/strictest/tsconfig.json",
"@tsconfig/node20/tsconfig.json"
],
"include": ["src/**/*"]
}
`;

const res = await extractPackageFile(
'regex',
fileContent,
'tsconfig.json',
customManager!,
);

expect(res?.deps).toMatchObject([
{
currentValue: '20',
datasource: 'npm',
depName: '@tsconfig/node20',
},
]);
});

describe('matches regexes patterns', () => {
it.each`
path | expected
Expand Down
5 changes: 2 additions & 3 deletions lib/config/presets/internal/custom-managers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,13 @@ export const presets: Record<string, Preset> = {
tsconfigNodeVersions: {
customManagers: [
{
autoReplaceStringTemplate:
'"extends": "@tsconfig/node{{{major}}}/tsconfig.json"',
autoReplaceStringTemplate: '"@tsconfig/node{{{major}}}/tsconfig.json"',
currentValueTemplate: '{{{major}}}',
customType: 'regex',
datasourceTemplate: 'npm',
managerFilePatterns: ['**/tsconfig.json'],
matchStrings: [
'"extends":\\s*"(?<depName>@tsconfig/node(?<major>\\d+))/tsconfig\\.json"',
'"(?<depName>@tsconfig/node(?<major>\\d+))/tsconfig\\.json"',
],
},
],
Expand Down