resolve some comments

renproject · Nov 14, 2021 · 6bbf625 · 6bbf625
1 parent 067a2c5
commit 6bbf625
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -226,3 +226,7 @@ or a script file
 ```sh
 darknode exec YOUR-DARKNODE-NAME --file test.sh
 ``` 
+
+### Github rate limiting
+
+You can set the `GITHUB_TOKEN` environment variable to increase your github rate limit. 
diff --git a/cmd/down.go b/cmd/down.go
@@ -56,7 +56,7 @@ func (s status) err() string {
 func destroyNode(ctx *cli.Context) error {
 	force := ctx.Bool("force")
 	name := ctx.Args().First()
-	if err := util.NodeExistence(name); err != nil {
+	if err := util.ValidateNodeExistence(name); err != nil {
 		return err
 	}
 	path := util.NodePath(name)
@@ -103,7 +103,7 @@ func withdraw(ctx *cli.Context) error {
 
 	// Parse the input parameters
 	name := ctx.Args().First()
-	if err := util.NodeExistence(name); err != nil {
+	if err := util.ValidateNodeExistence(name); err != nil {
 		return err
 	}
 	withdrawAddress := ctx.String("address")

diff --git a/cmd/main.go b/cmd/main.go
@@ -78,7 +78,7 @@ func main() {
 			Usage: "SSH into one of your Darknode",
 			Action: func(c *cli.Context) error {
 				name := c.Args().First()
-				if err := util.NodeExistence(name); err != nil {
+				if err := util.ValidateNodeExistence(name); err != nil {
 					return err
 				}
 				ip, err := util.IP(name)
@@ -151,7 +151,7 @@ func main() {
 			Flags: []cli.Flag{},
 			Action: func(c *cli.Context) error {
 				name := c.Args().First()
-				if err := util.NodeExistence(name); err != nil {
+				if err := util.ValidateNodeExistence(name); err != nil {
 					return err
 				}
 

diff --git a/cmd/provider/provider.go b/cmd/provider/provider.go
@@ -77,7 +77,7 @@ func validateCommonParams(ctx *cli.Context) error {
 	if err := util.ValidateName(name); err != nil {
 		return err
 	}
-	if err := util.NodeExistence(name); err == nil {
+	if err := util.ValidateNodeExistence(name); err == nil {
 		return fmt.Errorf("node [%v] already exist", name)
 	}
 

diff --git a/cmd/resize.go b/cmd/resize.go
@@ -29,7 +29,7 @@ var (
 
 func resize(ctx *cli.Context) error {
 	name := ctx.Args().Get(0)
-	if err := util.NodeExistence(name); err != nil {
+	if err := util.ValidateNodeExistence(name); err != nil {
 		return err
 	}
 	newSize := ctx.Args().Get(1)

diff --git a/util/node.go b/util/node.go
@@ -34,7 +34,7 @@ func ParseNodesFromNameAndTags(name, tags string) ([]string, error) {
 	} else if name == "" && tags != "" {
 		return GetNodesByTags(tags)
 	} else if name != "" && tags == "" {
-		return []string{name}, NodeExistence(name)
+		return []string{name}, ValidateNodeExistence(name)
 	} else {
 		return nil, ErrTooManyArguments
 	}
@@ -59,8 +59,8 @@ func ValidateName(name string) error {
 	return nil
 }
 
-// NodeExistence checks if there exists a node with given name.
-func NodeExistence(name string) error {
+// ValidateNodeExistence checks if there exists a node with given name.
+func ValidateNodeExistence(name string) error {
 	path := filepath.Join(Directory, "darknodes", name)
 	_, err := os.Stat(path)
 	return err