Security Fixes #35
Merged
Security Fixes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
commented
Jan 3, 2024
| @@ -5,8 +5,6 @@ gemspec | |||
| group :development, :test do | |||
| gem 'pry-byebug' | |||
| gem 'rack-test' | |||
| gem 'rails' | |||
| gem 'rails-api' | |||
There was a problem hiding this comment.
I didn't see these referenced anywhere so I removed them. It appears removing these two gems takes care of most of the reported vulnerabilities (they were never real vulnerabilities that could be exploited outside of the dev env).
Stratus3D
commented
Jan 3, 2024
| @@ -15,12 +15,4 @@ RSpec::Core::RakeTask.new(:spec) do |t| | |||
| t.pattern = 'spec/ops/**/*_spec.rb' | |||
| end | |||
|
|
|||
| desc 'Executes the example tests' | |||
| task 'test:examples' do | |||
| %w(rails_app_sample sinatra).each do |ex| | |||
There was a problem hiding this comment.
These sample apps had already been removed so this Rake task didn't work anymore.
Stratus3D
commented
Jan 3, 2024
| $stderr.puts e.message | ||
| $stderr.puts 'Run `bundle install` to install missing gems' | ||
| $stderr.warn e.message | ||
| $stderr.warn 'Run `bundle install` to install missing gems' |
There was a problem hiding this comment.
Rubocop yelled at me about these.
Stratus3D
commented
Jan 3, 2024
| # pass arguments to test call. This is useful for calling a single test. | ||
| bundle exec rspec "$1" | ||
| else | ||
| bundle exec rake test:examples && bundle exec rspec |
There was a problem hiding this comment.
rake test:examples is gone.
Stratus3D
commented
Jan 3, 2024
| bundle exec rubocop -D $auto_correct | ||
|
|
||
| if [[ -n "$1" && $1 != "-a" ]]; then |
There was a problem hiding this comment.
Shellcheck complained about these.
joshdayan
approved these changes
Jan 3, 2024
rkledesma
approved these changes
Jan 4, 2024
Stratus3D
force-pushed
the
tb/SRV-5995-security-fixes
branch
from
064d2be
to
d41db0e
Compare
[Card](https://rentpath.atlassian.net/browse/SRV-5995) * Remove test:examples Rake task as sample apps have been removed * Remove reference to old Rake task in script/test * Remove rails and rails-api as dependencies * Bump version
Stratus3D
force-pushed
the
tb/SRV-5995-security-fixes
branch
from
d41db0e
to
fe2846e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card