Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding tracing instrument spans to handlers and providers #391

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds additional tracing instruments to handlers and providers for the additional span logs in case of errors and for proper debugging.

Resolves #372

🚧 Stacked on top of the #387

How Has This Been Tested?

Logs are exposed with proper tracing instrument spans.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Nov 23, 2023
@arein arein added the accepted The issue has been accepted into the project label Nov 23, 2023
@geekbrother geekbrother changed the title Max/chore/additional instruments chore: adding tracing instrument spans to handlers and providers Nov 23, 2023
@geekbrother geekbrother changed the base branch from master to max/chore/wraping_to_request_id November 23, 2023 22:10
@geekbrother geekbrother marked this pull request as ready for review November 23, 2023 22:56
src/handlers/identity.rs Outdated Show resolved Hide resolved
Base automatically changed from max/chore/wraping_to_request_id to master November 27, 2023 09:07
@geekbrother geekbrother force-pushed the max/chore/additional_instruments branch from 1d1e750 to 9640733 Compare November 27, 2023 17:31
src/handlers/identity.rs Outdated Show resolved Hide resolved
src/handlers/identity.rs Outdated Show resolved Hide resolved
@geekbrother geekbrother merged commit 6053dfc into master Nov 28, 2023
@geekbrother geekbrother deleted the max/chore/additional_instruments branch November 28, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: wrap all calls into request id
3 participants