feat(CA): adding transaction simulation #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
feat/add_tenderly_sim
branch
from
3a7442f to
cbe0e7b
Compare
geekbrother
force-pushed
the
feat/add_tenderly_sim
branch
from
cbe0e7b to
e049391
Compare
geekbrother
force-pushed
the
feat/add_tenderly_sim
branch
from
e049391 to
05b6a30
Compare
chris13524
reviewed
Dec 9, 2024
chris13524
reviewed
Dec 9, 2024
chris13524
reviewed
Dec 9, 2024
src/handlers/chain_agnostic/mod.rs
Outdated
| /// Compute the storage slot for a given address and slot number to use in the | ||
| /// simulation state overrides | ||
| /// https://docs.tenderly.co/simulations/state-overrides#storage-slot-calculation | ||
| pub fn compute_simulation_storage_slot(address: Address, slot_number: u64) -> Bytes { |
There was a problem hiding this comment.
We shouldn't need to convert to/from hex in order to concatenate some bytes together
There was a problem hiding this comment.
Updated the implementation a bit, but we still need to contact two B256 and use this for the keccak.
chris13524
reviewed
Dec 9, 2024
geekbrother
force-pushed
the
feat/add_tenderly_sim
branch
2 times, most recently
from
49870b7 to
49cdfce
Compare
geekbrother
changed the title
This is a quite big PR and a lot of changes, let's merge this first and I'll add gas with the caching as a follow-up (don't want to make two monster stacked PRs 😅). |
chris13524
approved these changes
Dec 11, 2024
geekbrother
force-pushed
the
feat/add_tenderly_sim
branch
from
49cdfce to
473814d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the transaction simulation using the Tenderly simulation provider to the chain abstraction route endpoint to check for the ERC20 asset changes in case the initial transaction is not an ERC20 transfer.
How Has This Been Tested?
Integration tests update TBD.
Due Diligence