This repository was archived by the owner on Dec 8, 2025. It is now read-only.
fix: change publish to use http relay client in handlers#142
Merged
geekbrother merged 1 commit intomainfrom Oct 24, 2023
Merged
fix: change publish to use http relay client in handlers#142geekbrother merged 1 commit intomainfrom
publish to use http relay client in handlers#142geekbrother merged 1 commit intomainfrom
Conversation
geekbrother
force-pushed
the
max/fix/change_publish_to_http
branch
from
f5c13f6 to
64620e5
Compare
3 tasks
chris13524
suggested changes
Oct 23, 2023
Member
chris13524
left a comment
chris13524
left a comment
There was a problem hiding this comment.
Don't we need this for the /notify endpoint too?
Contributor
Author
I think not because we are already using the HTTP relay client when processing publishing jobs. |
chris13524
suggested changes
Oct 24, 2023
Member
Ah you're right |
geekbrother
force-pushed
the
max/fix/change_publish_to_http
branch
from
64620e5 to
815bbc8
Compare
chris13524
approved these changes
Oct 24, 2023
geekbrother
force-pushed
the
max/fix/change_publish_to_http
branch
from
815bbc8 to
ac1fb8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the use of
publishfrom websocket client to the HTTP relay client to solve the websocket disconnect issue.Resolves #74
How Has This Been Tested?
Integration test.
Due Diligence