This repository was archived by the owner on Dec 8, 2025. It is now read-only.
fix: watcher account not updated#157
Merged
chris13524 merged 1 commit intomainfrom Nov 1, 2023
Merged
Conversation
geekbrother
approved these changes
Oct 27, 2023
Contributor
geekbrother
left a comment
geekbrother
left a comment
There was a problem hiding this comment.
LGTM. Is there any reason why we are not updating account and project before? Or it just was missed?
Member
Author
|
@geekbrother I think I just missed it when implementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per the specs, account is supposed to be updated if the same did:key is used to call watchSubscriptions. Furthremore, it makes sense to update the
appbeing watched, so I submitted a specs change for this too.Resolves #156
How Has This Been Tested?
Not tested. Not covered by automated tests.
Due Diligence