refactor: using only update_message_processing_status to change status
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
changed the title
update_message_processing_status only to change statusupdate_message_processing_status to change status
geekbrother
force-pushed
the
max/feat/observe_queue_count
branch
3 times, most recently
from
28e45d3 to
08a6b6d
Compare
geekbrother
force-pushed
the
max/refactor/use_update_message_processing_status
branch
from
a7720bd to
0128598
Compare
geekbrother
force-pushed
the
max/feat/observe_queue_count
branch
2 times, most recently
from
9830d5c to
9f7f6ba
Compare
geekbrother
force-pushed
the
max/refactor/use_update_message_processing_status
branch
from
077951d to
6d22cef
Compare
geekbrother
deleted the
max/refactor/use_update_message_processing_status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a small refactor to use
update_message_processing_statushelper function to change the message status instead of manually running the SQL.This is useful for tracking metrics inside the
update_message_processing_statusfunction and following the DRY.update_message_processing_status only to change statusto be used with PgPool and Pg transactions,Resolves #189
How Has This Been Tested?
Just a build-and-up local smoke test.
Due Diligence