Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EIP-1271 #301

Merged
merged 7 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
825 changes: 810 additions & 15 deletions Cargo.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ futures = "0.3.26"
futures-util = "0.3"
dashmap = "5.4.0"

relay_rpc = { git = "https://github.com/WalletConnect/WalletConnectRust.git", tag = "v0.24.0", features = ["cacao"] }
relay_client = { git = "https://github.com/WalletConnect/WalletConnectRust.git", tag = "v0.24.0" }
relay_rpc = { git = "https://github.com/WalletConnect/WalletConnectRust.git", branch = "feat/eip1271", features = ["cacao"] }
relay_client = { git = "https://github.com/WalletConnect/WalletConnectRust.git", branch = "feat/eip1271" }
x25519-dalek = { version = "2.0.0", features = ["static_secrets"] }
hkdf = "0.12.3"
sha2 = "0.10.6"
Expand Down
3 changes: 2 additions & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ allow = [
"Unlicense",
"BSD-3-Clause",
"0BSD",
"ISC"
"ISC",
"CC0-1.0"
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a dependency changed and this license is actually being used. A few weeks ago the checker had me remove it because it was unused, but now it wanted me to add back. Not sure what happened.

This license is a public domain license so we can allow it.


exceptions = [{ name = "unicode-ident", allow = ["Unicode-DFS-2016"] }]
Expand Down
7 changes: 6 additions & 1 deletion src/auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use {
types::{AccountId, AccountIdParseError},
},
registry::storage::{redis::Redis, KeyValueStorage},
BlockchainApiProvider,
},
base64::{DecodeError, Engine},
chrono::{DateTime, Duration as CDuration, Utc},
Expand Down Expand Up @@ -665,6 +666,7 @@ pub async fn verify_identity(
ksu: &str,
sub: &str,
redis: Option<&Arc<Redis>>,
provider: &BlockchainApiProvider,
metrics: Option<&Metrics>,
) -> Result<Authorization, NotifyServerError> {
let mut url = Url::parse(ksu)?.join(KEYS_SERVER_IDENTITY_ENDPOINT)?;
Expand All @@ -680,7 +682,10 @@ pub async fn verify_identity(

let account = AccountId::from_did_pkh(&cacao.p.iss).map_err(AuthError::CacaoIssNotDidPkh)?;

let always_true = cacao.verify().map_err(AuthError::CacaoValidation)?;
let always_true = cacao
.verify(provider)
.await
.map_err(AuthError::CacaoValidation)?;
assert!(always_true);

// TODO verify `cacao.p.aud`. Blocked by at least https://github.com/WalletConnect/walletconnect-utils/issues/128
Expand Down
5 changes: 4 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ use {
aws_sdk_s3::{config::Region, Client as S3Client},
error::NotifyServerError,
rand::prelude::*,
relay_rpc::auth::ed25519_dalek::Keypair,
relay_rpc::auth::{
cacao::signature::eip1271::blockchain_api::BlockchainApiProvider, ed25519_dalek::Keypair,
},
sqlx::postgres::PgPoolOptions,
std::sync::Arc,
tokio::{select, sync::broadcast},
Expand Down Expand Up @@ -116,6 +118,7 @@ pub async fn bootstrap(
redis,
registry,
config.clock,
BlockchainApiProvider::new(config.project_id),
)?);

let private_http_server =
Expand Down
1 change: 1 addition & 0 deletions src/services/websocket_server/handlers/notify_delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ pub async fn handle(
&request_auth.ksu,
&request_auth.sub,
state.redis.as_ref(),
&state.provider,
state.metrics.as_ref(),
)
.await
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ pub async fn handle(msg: PublishedMessage, state: &AppState) -> Result<(), Relay
&request_auth.ksu,
&request_auth.sub,
state.redis.as_ref(),
&state.provider,
state.metrics.as_ref(),
)
.await
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ pub async fn handle(msg: PublishedMessage, state: &AppState) -> Result<(), Relay
&request_auth.ksu,
&request_auth.sub,
state.redis.as_ref(),
&state.provider,
state.metrics.as_ref(),
)
.await
Expand Down
1 change: 1 addition & 0 deletions src/services/websocket_server/handlers/notify_update.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ pub async fn handle(msg: PublishedMessage, state: &AppState) -> Result<(), Relay
&request_auth.ksu,
&request_auth.sub,
state.redis.as_ref(),
&state.provider,
state.metrics.as_ref(),
)
.await
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ pub async fn handle(msg: PublishedMessage, state: &AppState) -> Result<(), Relay
&request_auth.ksu,
&request_auth.sub,
state.redis.as_ref(),
&state.provider,
state.metrics.as_ref(),
)
.await
Expand Down
7 changes: 6 additions & 1 deletion src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ use {
Configuration,
},
build_info::BuildInfo,
relay_rpc::auth::ed25519_dalek::Keypair,
relay_rpc::auth::{
cacao::signature::eip1271::blockchain_api::BlockchainApiProvider, ed25519_dalek::Keypair,
},
serde::{Deserialize, Serialize},
sqlx::PgPool,
std::{fmt, sync::Arc},
Expand All @@ -29,6 +31,7 @@ pub struct AppState {
pub registry: Arc<Registry>,
pub notify_keys: NotifyKeys,
pub clock: Clock,
pub provider: BlockchainApiProvider,
}

build_info::build_info!(fn build_info);
Expand All @@ -47,6 +50,7 @@ impl AppState {
redis: Option<Arc<Redis>>,
registry: Arc<Registry>,
clock: Clock,
provider: BlockchainApiProvider,
) -> Result<Self, NotifyServerError> {
let build_info: &BuildInfo = build_info();

Expand All @@ -65,6 +69,7 @@ impl AppState {
registry,
notify_keys,
clock,
provider,
})
}

Expand Down
14 changes: 7 additions & 7 deletions tests/deployment.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use {
crate::utils::{
encode_auth, generate_account, verify_jwt, UnregisterIdentityRequestAuth, JWT_LEEWAY,
RELAY_MESSAGE_DELIVERY_TIMEOUT,
encode_auth, generate_account, verify_jwt, MockGetRpcUrl, UnregisterIdentityRequestAuth,
JWT_LEEWAY, RELAY_MESSAGE_DELIVERY_TIMEOUT,
},
base64::Engine,
chacha20poly1305::{
Expand Down Expand Up @@ -50,7 +50,7 @@ use {
rand::{rngs::StdRng, SeedableRng},
relay_rpc::{
auth::{
cacao::{self, signature::Eip191},
cacao::{self, signature::eip191::eip191_bytes},
ed25519_dalek::Keypair,
},
domain::{DecodedClientId, ProjectId},
Expand Down Expand Up @@ -411,14 +411,14 @@ async fn run_test(statement: String, watch_subscriptions_all_domains: bool) {
},
};
let (signature, recovery): (k256::ecdsa::Signature, _) = account_signing_key
.sign_digest_recoverable(Keccak256::new_with_prefix(
Eip191.eip191_bytes(&cacao.siwe_message().unwrap()),
))
.sign_digest_recoverable(Keccak256::new_with_prefix(eip191_bytes(
&cacao.siwe_message().unwrap(),
)))
.unwrap();
let cacao_signature = [&signature.to_bytes()[..], &[recovery.to_byte()]].concat();
cacao.s.t = "eip191".to_owned();
cacao.s.s = hex::encode(cacao_signature);
cacao.verify().unwrap();
cacao.verify(&MockGetRpcUrl).await.unwrap();

let response = reqwest::Client::builder()
.build()
Expand Down
Loading
Loading