feat: unread first #429
Merged
feat: unread first #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
commented
Mar 21, 2024
| " | ||
| AND ( | ||
| {unread_first_clause_left} | ||
| NOW() - (SELECT created_at FROM subscriber_notification WHERE id={variable}), |
There was a problem hiding this comment.
Looks like there's no way to reverse the comparison for a specific field in the tuple, so have to make it subtract from a shared value to make it sort in reverse.
chris13524
commented
Mar 21, 2024
| ) | ||
| subscriber_notification.is_read ASC, | ||
| subscriber_notification.created_at DESC, | ||
| subscriber_notification.id ASC |
There was a problem hiding this comment.
Technically this changes the sort order from higher ID first to lower ID first. But this was used as a tie-breaker only when created_at was the same. This just guarantees that when paginating that there is no risk of missing or duplicate notifications and I think it makes more sense to put lower IDs first in the tiebreaker.
nopestack
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the
urfflag as per the specsAlso rewrites some related test cases (that I just made in last PR) to be simpler and more maintainable.
Resolves #427
How Has This Been Tested?
New test cases
Due Diligence