Translations #102
Merged
Translations #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into translations
+ add elasticsearch & pgsync
merge main
Translations
Frando
reviewed
Jun 21, 2024
docker/docker-compose.build.yml
Outdated
| - REPCO_ADMIN_TOKEN=kUBY0zsPHC9ubj3T6DZJKUACi3M= | ||
| - REPCO_URL=http://localhost:8765 | ||
| - CBA_API_KEY=k8WHfNbal0rjIs2f | ||
| - AP_BASE_URL=http://localhost:8765/ap |
There was a problem hiding this comment.
The AP_BASE_URL can be removed now that #101 is merged
| @@ -591,9 +611,14 @@ export class ActivityPubDataSource | |||
| subtitleEntities && entities.push(...subtitleEntities) | |||
| } | |||
|
|
|||
| var titleJson: { [k: string]: any } = {} | |||
| titleJson[video.language?.name || 'de'] = { value: video.name } | |||
There was a problem hiding this comment.
Ingo reported a bug about English appearing as an object key, where it should be en. I suspect this line being the cause.
I also noticed an error: Title contains e.g. the word “English” as an object key. There should be a two-digit language code “en” in there.
"title": {
"English": {
"value": "A step to the left, a step to the right: the new European centre"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reworked db schema for multilingual support