feat: continue ingest after errors #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the error handling in the ingest process. We now store failures during ingest in the database, and continue if the fatal is non-fatal.
fetchUpdates
fails, we apply a delay of 30s until we try again, as this is likely a network or external issues.This means that for all errors that can happen due to external circumstances (datasource offline, datasource emits bad data), we do not abort but log the errors and try to continue. We only abort right away for other errors, which should not happen (to be treated as bugs in repco).
The PR also includes a new CLI command,
ds errors
, to show the errors: