[WIP] feat: webcomponent #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(feat) Repo with signed DAG-CBOR blocks
add a run command to run server, datasource ingest and repo sync in parallel. add some utitilites for long running tasks. also includes fix in rss datasource to retry failed requests.
feat: run command to run everything in parallel
chore: lint fix and fmt
* create dockerfile * add CI to publish images
Frando
reviewed
Feb 3, 2023
Frando
reviewed
Feb 3, 2023
Frando
reviewed
Feb 3, 2023
Frando
reviewed
Feb 3, 2023
Frando
reviewed
Feb 3, 2023
Frando
reviewed
Feb 3, 2023
| @property() | ||
| body = ''; | ||
| override render() { | ||
| return html`${unsafeHTML(this.body)}`; |
There was a problem hiding this comment.
this is .. unsafe ;) we likely need to check the HTML there. or only allow strings not html. we cannot inject any HTML coming from the repco node into the DOM, this opens it up to XSS etc vulnerabilities.
this is a bit of a bigger issue that we'll have to address in repco. for now, we should either sanitze the HTML here or convert it to string only (remove all html tags).
Open
|
moved to oas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a repco recomender box