Auto power : ENABLE_POWER_ON_STARTUP == 2 only turn on power pin when heat required #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tbed required Only turn on power pin when hotend and or heatbed are enabled (target temperature >= 20) and no sensor defect present otherwise turn off power pin as a safety feature
Explain available settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping you will merge this low impact change which adds a new safety feature. This is primarily for RAMPS-FD v1 (with inverted heater controls). I have only proposed this on the Due tree as I'm not sure AVR has any boards with inverted heaters. RAMPS-FD v1 is still the only version readily available as of Feb-2017 and this is the most straightforward solution to reduce the risk of any thermal runaway. Changes are isolated with #ifdef and should not have any impact for users who do not require it. ENABLE_POWER_ON_STARTUP == 2 is handled in Extruder::manageTemperatures() and enables / disables the power pin when heat is required and would therefore allow heatbed / hotend power to be isolated via relay or similar method. Please let me know if any changes required to merge.