Merge pull request #93 from replayio/openhands-fix-issue-90-try3

Fix issue #90: Task 14 (Trial 2): Fix network data by extension issues
replayio · Dec 19, 2024 · 8e44297 · 8e44297
2 parents 00bfd36 + 34b8b65
commit 8e44297
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 15 deletions.
diff --git a/src/components/performance/PerformanceComparison.tsx b/src/components/performance/PerformanceComparison.tsx
@@ -42,20 +42,22 @@ export function NetworkDataComparison({ data, mainBranchData }: NetworkDataProps
     <div className="mt-2">
       <h4 className="font-semibold">Network Data by Extension:</h4>
       <div className="ml-4">
-        {Array.from(allExtensions).map(ext => {
-          const value = data[ext] || 0;
-          const mainValues = mainBranchData.map(d => d[ext] || 0);
-          return (
-            <ComparisonValue
-              key={ext}
-              label={ext}
-              value={value}
-              mainBranchValues={mainValues}
-              unit=" bytes"
-              formatFn={bytes => (bytes / 1024).toFixed(1) + " KB"}
-            />
-          );
-        })}
+        {Array.from(allExtensions)
+          .sort((a, b) => (data[b] || 0) - (data[a] || 0))
+          .map(ext => {
+            const value = data[ext] || 0;
+            const mainValues = mainBranchData.map(d => d[ext] || 0);
+            return (
+              <ComparisonValue
+                key={ext}
+                label={ext}
+                value={value}
+                mainBranchValues={mainValues}
+                unit=""
+                formatFn={bytes => (bytes / 1024).toFixed(1) + " KB"}
+              />
+            );
+          })}
       </div>
     </div>
   );

diff --git a/src/performance/networkData.ts b/src/performance/networkData.ts
@@ -9,7 +9,7 @@ export function computeNetworkDataByExtension(requests: NetworkRequest[]) {
       const pathname = url.pathname;
       let ext = pathname.substring(pathname.lastIndexOf('.') + 1).toLowerCase() || 'no-extension';
 
-      if (ext.includes('/') || ext.length > 6) {
+      if (ext.includes('/') || ext.length > 6 || ext === 'map') {
         ext = 'unknown';
       }