Skip to content

Remove some old asserts that I was working on before the pivot #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove some old asserts that I was working on before the pivot #1313

merged 1 commit into from
Dec 13, 2024

Conversation

@Domiii
Copy link

@Domiii Domiii commented Dec 12, 2024

Removing old noisy asserts I needed for (IIRC) 2 sets of divergences:

  1. CSS divergences ((dis-)continued in Assert access checks + more UseCounter code #1291)
  2. V8 serialization (mostly fixed?)

@Domiii Domiii requested a review from bhackett1024 December 12, 2024 11:24
@Domiii Domiii self-assigned this Dec 12, 2024
@Domiii Domiii merged commit d7709cb into master Dec 13, 2024
3 of 5 checks passed
@Domiii Domiii deleted the dominik/366-remove-asserts branch December 13, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhackett1024 bhackett1024 bhackett1024 approved these changes

Assignees

@Domiii Domiii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Domiii @bhackett1024