Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #158

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix broken links #158

merged 1 commit into from
May 21, 2024

Conversation

jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented May 18, 2024

This uses npm run links to find broken links across the docs proactively in vercel.json and other pages.

Other fixes

  • checkLinks was previously checking the first five files.
  • adds a lint check
  • cancels the fetch after 5 seconds

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replay-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 7:36am

@jasonLaster
Copy link
Contributor Author

@jonbell-lot23 i'm surprised you dont have feedback here. Do you think check-links is in a good place after this? Does this fix the broken links? Are there any issues with these changes? I threw this together quickly late on a friday night

@jonbell-lot23
Copy link
Contributor

jonbell-lot23 commented May 20, 2024

@jonbell-lot23 i'm surprised you dont have feedback here. Do you think check-links is in a good place after this? Does this fix the broken links? Are there any issues with these changes? I threw this together quickly late on a friday night

Yup, before this tool was failing and now it's succeeding. I confirmed with you on the call, and again on my end. I didn't look seriously into the quality of the code, just confirmed things are green and looking right.

@jasonLaster jasonLaster merged commit c804da1 into main May 21, 2024
7 checks passed
@jasonLaster
Copy link
Contributor Author

Will merge because otherwise it's a rebase nightmare. there wil likely be some fall out though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants