fix misc. typos #185
Merged
fix misc. typos #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
miriambudayr
commented
May 31, 2024
| @@ -56,7 +56,7 @@ Because of this, a flaky test does not feel like an act of higher force, but can | |||
|
|
|||
| Replay Devtools work great with your existing test suite. Cypress and Playwright plugins allow you to **rewind or fast forward** to any command from your test run. | |||
|
|
|||
| The command details panel contains information on passed arguments, returned values and targeted element. Commands are integrated with the rest of DevTools. This means you can jump from a command detail into [Elements panel](/basics/replay-devtools/browser-devtools/elements-panel), or inspect API calls in the [Network panel](/basics/replay-devtools/browser-devtools/network-monitor). | |||
| The command details panel contains information on passed arguments, returned values, and targeted elements. Commands are integrated with the rest of DevTools. This means you can jump from a command detail into the [Elements panel](/basics/replay-devtools/browser-devtools/elements-panel), or inspect API calls in the [Network panel](/basics/replay-devtools/browser-devtools/network-monitor). | |||
There was a problem hiding this comment.
I'm partial to the Oxford comma. Regardless, I think we should choose one and make that the law of the land.
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm partial to the Oxford comma.
Same
I think we should choose one and make that the law of the land.
Big same
There was a problem hiding this comment.
I feel very strongly about this as well.
- Yes Oxford comma (and honestly the counter-arguments are not compelling at all)
- Yes to consistency
callingmedic911
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these while doing an onboarding audit:
https://www.notion.so/replayio/Miriam-next-js-onboarding-685cff62f032467bab8f1d6085a33544?showMoveTo=true&saveParent=true