Skip to content

Commit

Permalink
Make dockerfile generators abstract (#2088)
Browse files Browse the repository at this point in the history
* Make dockerfile generators abstract

* This allows us to add a fast build dockerfile
generator that we can sub out based on the fast
build flag.

* Use Capitals for GenerateInitialSteps
  • Loading branch information
8W9aG authored Dec 12, 2024
1 parent 7256462 commit fb03a00
Show file tree
Hide file tree
Showing 5 changed files with 733 additions and 701 deletions.
4 changes: 2 additions & 2 deletions pkg/dockerfile/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ func (g *BaseImageGenerator) GenerateDockerfile() (string, error) {
return "", err
}
useCogBaseImage := false
generator.useCogBaseImage = &useCogBaseImage
generator.SetUseCogBaseImagePtr(&useCogBaseImage)

dockerfile, err := generator.generateInitialSteps()
dockerfile, err := generator.GenerateInitialSteps()
if err != nil {
return "", err
}
Expand Down
Loading

0 comments on commit fb03a00

Please sign in to comment.