Add cancelation metadata to Redis #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some cancelation metadata to redis that allows API to introspect the
stream and message ID from the prediction ID. This allows api to perform
an `XDEL` on the redis message when a cancelation is received. The only
time an `XDEL` should happen is if the prediction has not started.
API will be responsible to check `XPENDING` and/or the prediciton cache.
Additionally API should `DEL` the meta key when it performs a
cancelation or when the prediction completes.
key format: `meta:cancelation:<prediction_id>` and it contains json
in the form of: `{"stream_id": "<stream key>", "msg_id": "<redis message
id>"}`
tempusfrangit
requested review from
meatballhat,
evilstreak and
philandstuff
|
This is an example of how we can signal the message id so that API can snipe the redis message out of the queue using an XDEL when a cancelation is received. This is a much cleaner way of handling cancelations that have not been picked up. Director can still decide if it wants to propagate cancelations to cog. API can look up this key, and if it exists, XDEL the message and move on ignoring the cancelation key that director would normall rely on (or we could still set it, if we want). TTL is subject to discussion on this new key. Additionally |
tempusfrangit
commented
Nov 21, 2024
| @@ -102,6 +112,15 @@ local id = redis.call('XADD', key_stream, '*', unpack(fields)) | |||
| -- Add a notification to the notifications stream | |||
| redis.call('XADD', key_notifications, 'MAXLEN', '1', '*', 's', selected_sid) | |||
|
|
|||
| if prediction_id ~= "" then | |||
| local key_prediction_meta_cancelation = ':meta:cancelation:' .. prediction_id | |||
| redis.CALL('SET', key_prediction_meta_cancelation, '{"stream_id":"' .. key_stream .. ',"prediction_id":"' .. prediction_id .. ',"msg_id":"' .. id .. '"}') | |||
There was a problem hiding this comment.
Suggested change
| redis.CALL('SET', key_prediction_meta_cancelation, '{"stream_id":"' .. key_stream .. ',"prediction_id":"' .. prediction_id .. ',"msg_id":"' .. id .. '"}') | |
| redis.CALL('SET', key_prediction_meta_cancelation, '{"stream_id":"' .. key_stream .. ',"msg_id":"' .. id .. '"}') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some cancelation metadata to redis that allows API to introspect the stream and message ID from the prediction ID. This allows api to perform an
XDELon the redis message when a cancelation is received. The only time anXDELshould happen is if the prediction has not started.API will be responsible to check
XPENDINGand/or the prediciton cache. Additionally API shouldDELthe meta key when it performs a cancelation or when the prediction completes.key format:
meta:cancelation:<prediction_id>and it contains json in the form of:{"stream_id": "<stream key>", "msg_id": "<redis message id>"}