[queue] remove legacy #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our loop bounds were wrong here. This isn't a big deal in len.lua because XLEN on a nonexistent key returns 0. It's not a big deal in read.lua because we immediately take (offset + idx) % streams, folding into the range [0, streams) anyway. It just means we check the original stream twice in the loop. However this breaks if you copy-paste the pattern for some other purpose, like calling XINFO GROUPS on a key. That command errors if the key doesn't exist.
This is now fully rolled out, we have no base streams any more. I have checked
this in all our clusters with:
KEYS input:prediction:??-????????????????????????????????
and found a bunch of empty streams with no TTLs. I manually deleted them.
philandstuff
force-pushed
the
queue-remove-legacy
branch
from
20e2f22 to
b8661f5
Compare
erbridge
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies a bunch of legacy code in the shuffle shard queue implementation.
This is paving the way to do stuff with PLAT-604.