PLAT-604 [queue] create Stats (to replace PendingCount) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just like #160, but we calculate length and pending count atomically. Before this change, I was subtracting the pending count from the length to get a "waiting messages" metric; but as these numbers could not be measured atomically I sometimes saw negative waiting messages. This changes PendingCount() into Stats() which returns both length and pending count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just like #160, but we calculate length and pending count atomically.
Before this change, I was subtracting the pending count from the length to get a "waiting messages" metric; but as these numbers could not be measured atomically I sometimes saw negative waiting messages.
This changes PendingCount() into Stats() which returns both length and pending count.