Fix Python version #493
Merged
Fix Python version #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't being passed through the stack correctly. Also added some sanity tests for the Python -> Go -> Python round trip. Signed-off-by: Ben Firshman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an incomplete implementation in #485. It wasn't being passed through the stack correctly. Also added
some sanity tests for the Python -> Go -> Python round trip.
As an aside, there are so many places that new fields need to be added. I wonder if there is a way this can be simplified, or the test can be generalized to get the round trip always works.
configis also kind of broken, but low priority. #492