feat(api): helm binary migration #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
force-pushed
the
emosbaugh/sc-130052/template-function-lookup
branch
from
1b9e6b9 to
001732c
Compare
emosbaugh
force-pushed
the
emosbaugh/sc-130052/template-function-lookup
branch
from
001732c to
1a8b27d
Compare
emosbaugh
changed the title
emosbaugh
commented
Oct 16, 2025
Comment on lines
+208
to
+212
| func (h *HelmClient) Latest(ctx context.Context, reponame, chart string) (string, error) { | ||
| // Use helm search repo with JSON output to find the latest version | ||
| args := []string{"search", "repo", fmt.Sprintf("%s/%s", reponame, chart), "--version", ">0.0.0", "--versions", "--output", "json"} | ||
|
|
||
| stdout, _, err := h.executor.ExecuteCommand(ctx, nil, nil, args...) |
There was a problem hiding this comment.
the binary is used here
emosbaugh
commented
Oct 16, 2025
Comment on lines
+293
to
+300
| func (h *HelmClient) GetChartMetadata(ctx context.Context, ref string, version string) (*chart.Metadata, error) { | ||
| // Use helm show chart to get chart metadata | ||
| args := []string{"show", "chart", ref} | ||
| if version != "" { | ||
| args = append(args, "--version", version) | ||
| } | ||
|
|
||
| stdout, _, err := h.executor.ExecuteCommand(ctx, nil, nil, args...) |
There was a problem hiding this comment.
the binary is used here
sgalsaleh
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Brings in some of the following pull request that does not touch the v2 codepath:
#2759
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?