arm64 metadata.json #3210
arm64 metadata.json #3210
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: False release success without metadata validation.
The validate-release-success job doesn't include upload-metadata in its dependencies. Since this PR adds ARM64 metadata generation and upload as a core release feature, the workflow could incorrectly report success even if metadata uploads fail. The job should depend on upload-metadata to ensure metadata files are successfully uploaded to both staging and production S3 buckets before marking the release as successful.
.github/workflows/release-prod.yaml#L676-L684
embedded-cluster/.github/workflows/release-prod.yaml
Lines 676 to 684 in ca8371b
| - name: Generate ${{ matrix.arch }} metadata | ||
| run: | | ||
| mkdir -p build | ||
| CLUSTER_ARCH=${{ matrix.arch }} ./output/bin/embedded-cluster version metadata > build/metadata-${{ matrix.arch }}.json |
There was a problem hiding this comment.
Bug: Mismatched Architecture SHA Corrupts ARM64 Metadata
The generate-metadata job downloads only the AMD64 binary but uses it to generate both AMD64 and ARM64 metadata by setting CLUSTER_ARCH. This causes the ARM64 metadata to contain the wrong K0sSHA value since goods.K0sBinarySHA256() reads the SHA from the embedded k0s binary in the AMD64 executable, not from an actual ARM64 binary. The ARM64 metadata will reference ARM64 artifact URLs but have an AMD64 k0s checksum, causing verification failures.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
What this PR does / why we need it:
This PR generates ARM64 metadata files to support future ARM64 deployments
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE