Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freyja integration #268

Merged
merged 6 commits into from
May 17, 2024
Merged

Freyja integration #268

merged 6 commits into from
May 17, 2024

Conversation

DataSpott
Copy link
Collaborator

Integration of Freyja for metagenomic screening of reads.
Includes also a restructuring of the LCS-tool for metagenomic read-analysis.

@DataSpott DataSpott added the enhancement New feature or request label May 13, 2024
@DataSpott DataSpott self-assigned this May 13, 2024
@hoelzer
Copy link
Collaborator

hoelzer commented May 13, 2024

@DataSpott okay, I pushed my changes to make the update for freyja happen in the work dir to also work with Singularity.

Please have a look, I also hope I set all the params correctly so it really uses the downloaded files in the workdir and does not fallback to the old files installed in the freyja conda env

Copy link
Owner

@replikation replikation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update stub otherwise okay

@hoelzer
Copy link
Collaborator

hoelzer commented May 17, 2024

please update stub otherwise okay

Can @DataSpott do that? Would be nice if we can merge this then and then we would also test further

@DataSpott
Copy link
Collaborator Author

Had already a look at it, but could not yet identify the reason why stub fails. Happens in the fast5-test but what I saw so far the stub-profiles are setup correctly. Need to investigate this further.

@DataSpott
Copy link
Collaborator Author

Found the error. Will now conduct a test run to make sure that everything works properly and report than if the merge can be done.

@replikation
Copy link
Owner

can be merged if everything is also fine on your end @hoelzer

@DataSpott
Copy link
Collaborator Author

Just to follow up: my "test_fast5"-profile run was successful with the latest changes.

@hoelzer
Copy link
Collaborator

hoelzer commented May 17, 2024

Also fine for me!

After the merge we should still keep an eye on any results bc as we discussed on BC I am not 100% certain the update parameter works as intended. I am 95% sure :)

We can test this with a very recent patient sample that has a very fresh lineage assignment (a lineage not assigned on March) and then see what the pipeline annotates with frejya in default mode and with update. As a sanity check

@replikation replikation merged commit ff6cb14 into master May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants