Fix codegen for fields with dashes #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
reviewed
Aug 4, 2025
Merged
jackyzha0
added a commit
that referenced
this pull request
Aug 18, 2025
Why === extension of #163 for encoder types What changed ============ fix the encoder by using the specialized_name with alias Test plan ========= wrote test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some new services require
-.and:in field namesWhat changed
When rendering a
TypeNameits value is normalized, and a newLiteralTypedataclass was added to avoid that normalization.Known limitation: this new normalization only works on output types.
Test plan
Run codegen on a schema with a field that has a
-in its name