chore: update to eslint 9 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedeericodl
added
refactor
semver: none
❌ Deploy Preview for replugged-docs failed.
|
|
Need to wait for a new node.js v20 version that fixes corepack issues. It should be out in a few days. |
|
Updated node and checks passed. PR out of draft. |
colin273
approved these changes
Mar 13, 2025
12944qwerty
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a major version upgrade to ESLint and some minor code improvements. The primary focus is on migrating to the new ESLint flat config, updating dependencies, and improving TypeScript type safety. Thanks to this change we leave the config dependency we have relied on in these years, now allowing greater control on it.
.eslintignoreand.eslintrc.yml) and replaced them with the new standard flat config witheslint.config.mjs. Most of the rules from the dependency have been ported to the new config to keep the current style of the repository as close as possible before this change. This new configuration includes recommended settings for ESLint, TypeScript, and React (added new), along with specific rules for various file types. In some specific cases comments have been added to ignore some linter rules, most of them are aboutno-unnecessary-condition. It's better to keep it enabled and disable it occasionally in very specific cases where it is necessary to keep the condition unnecessary.package.json. The package manager version was also updated from pnpm 9.x to pnpm 10.x.scripts/build-bin.mts,scripts/inject/checks/env.mts, andscripts/inject/index.mts.