-
Notifications
You must be signed in to change notification settings - Fork 134
Merge servarr stack #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge servarr stack #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please don't put these into separate file, this makes it harder to look for rules. Rulest should be spread alphabetically.
- Please only merge names which are not currently merged. For instance, for
sonarr
, onlysonarr-develop
needs merging, notsonarr-bin
,sonarr-develop-bin
,sonarr-nightly
, orsonarr-nightly-bin
-develop
and-nighly
merges needweak_devel: true, nolegacy: true
instead offlavor
Rules can be easily Regardless, I'll make the changes! EDIT: Are -bin packages automatically classified under their main project? If so, should I remove the -bin for sonarr? |
Okay, ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I've mentioned,
- You don't need flavors for nightly/develop. Note that you can also stick nightly and develop into the same rule where applicable.
- Please don't merge non-existing projects. Check project search first, if there's no e.g.
whisparr-nightly-bin
, rules should not mention it.
EDIT: Are -bin packages automatically classified under their main project? If so, should I remove the -bin for sonarr?
This depends on repository. They are for aur but aren't for gentoo, and that rule is needed for gentoo, so no, please don't remove it.
The nighties and develops should be the same version each respectively though. Is that handled without flavors? |
Repology does not check version equivalence between packages. develop/develop-bin/nightly/nightly-bin will be handled independently, but the same way, ignored if version higher than release version and outdated if lower. |
Okay, ready for review again! The *-nightly packages on the AUR have been merged into *-nightly-bin, so there aren't any *-nightly, there are only *-nightly-bin now. |
Rebased on master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please don't merge non-existing projects
This has not been fixed yet. See comments for examples.
Signed-off-by: txtsd <[email protected]>
Now it makes sense! I was thinking in terms of packages, not projects. I've got the hang of it now for future contributions! Ready for (hopefully final) review~ |
Can you also show me how to mark some repositories' packages as develop? For example in radarr, |
We just mark these repositories as untrusted. Marking version range as devel is possible, but that would require regular manual updating of a rule, we don't want that. It would be better if upstream conveyed release status in a versioning scheme, such as using |
Okay I'll open a new PR for the rest of the packages. Thanks for showing me how! I'm the maintainer of Also, how often is the website updated? |
Once each 4-5 hours. |
I see Without that we'd have to make a rule for each develop version that lands 👀 |
We just ban whole repository (which provides unstable version) untrusted, you don't need to specify versions for that. |
It's my first time contributing in this repo.
I'm going to use
${servarr}
as a variable to denote any *arr app to explain what this PR aims to achieve.${servarr}
and${servarr}-bin
should be the same version.${servarr}-develop
and${servarr}-develop-bin
should be the same version, and they are development versions.${servarr}-nightly
and${servarr}-nightly-bin
should be the same version, and they are also development versions.Please let me know if my yaml-fu is correct, or if it needs changing~