Split mp3cat, merge mp3cat-go #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're missing a split rule to assign unique name for another kind of mp3cat. You also need to merge mp3cat-go into mp3cat so all mp3cats go through the same split rules. |
|
To clarify, the other kind of mp3cat rightfully has the name In any case, I've also thought about renaming all packages - Tom Clegg's |
|
|
TheRealKeto
force-pushed
the
split/mp3cat
branch
from
41dd45f to
e8ff99c
Compare
AMDmi3
requested changes
Dec 1, 2024
TheRealKeto
force-pushed
the
split/mp3cat
branch
from
e8ff99c to
4e9120e
Compare
AMDmi3
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some ambiguity between two projects with the same name.
mp3catwas originally written by Tom Clegg, yet there exists a different project written by someone else with the same name, only it has a different function and is written in Go.For Termux, Repology already recognizes the correct name of the package (
mp3cat-go), so this serves as a change that will split the packages in two, which should also fix issues regarding versions, which also differ (0.5 vs. 4.2.2)