Feature/update circuit instance #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 19, 2018 11:25
lib: commented out tests that need to be completely re-written
added 10 commits
December 20, 2018 15:02
circuit/builder/mod: Adds Ord for WireId, need for fix
…, improves CanConvert and create set_from_num
… to Into<WireId> lib: added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make
CircuitInstancegeneric enough to handle any type of structure containingWireIds.I wanted to get some early feedback on this while I write more tests to ensure it functions as we expect. (Tests don't cause controversy)
The hope is to get feedback, make improvements and merge by Friday.
Note: Still missing Macro for ease of use.