Skip to content

Commit

Permalink
fix(loans): anonymize notification's recipients
Browse files Browse the repository at this point in the history
- Closes #3807.

Co-Authored-by: Pascal Repond <[email protected]>
  • Loading branch information
PascalRepond committed Jan 16, 2025
1 parent 37d695c commit bb568b6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions rero_ils/modules/loans/logs/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,6 @@ def anonymize_logs(cls, loan_pid):
record = log.to_dict()
record["loan"]["patron"]["name"] = "anonymized"
record["loan"]["patron"]["pid"] = "anonymized"
if record["record"]["type"] == "notif":
record["notification"]["recipients"] = ["anonymized"]
cls.update(log.meta.id, log["date"], record)
6 changes: 6 additions & 0 deletions tests/ui/loans/test_loans_operation_logs.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ def test_anonymize_logs(item2_on_loan_martigny_patron_and_loan_on_loan):
logs = LoanOperationLogsSearch().get_logs_by_record_pid(loan["pid"])
assert len(logs) == 3
for log in logs:
if log["record"]["type"] == "notif":
assert log["notification"]["recipients"] == [
"[email protected]"
]
assert log["loan"]["patron"]["pid"] == patron["pid"]
assert log["loan"]["patron"]["name"] == "Roduit, Louis"

Expand All @@ -114,3 +118,5 @@ def test_anonymize_logs(item2_on_loan_martigny_patron_and_loan_on_loan):
assert log["loan"]["patron"]["hashed_pid"] == f"{md5_hash}"
assert log["loan"]["patron"].get("name") == "anonymized"
assert log["loan"]["patron"].get("pid") == "anonymized"
if log["record"]["type"] == "notif":
assert log["notification"]["recipients"] == ["anonymized"]

0 comments on commit bb568b6

Please sign in to comment.