try removing RR_WITH_MAYBE_UNINITIALIZED_DISABLED from builder meth…

…ods 🤞🤞🤞
rerun-io · Jan 22, 2025 · 76d2278 · 76d2278
1 parent 6718d1c
commit 76d2278
Show file tree

Hide file tree

Showing 63 changed files with 306 additions and 678 deletions.
diff --git a/crates/build/re_types_builder/src/codegen/cpp/mod.rs b/crates/build/re_types_builder/src/codegen/cpp/mod.rs
@@ -587,11 +587,6 @@ impl QuotedObject {
             let field_type = quote_archetype_unserialized_type(&mut hpp_includes, obj_field);
             let descriptor = archetype_component_descriptor_constant_ident(obj_field);
 
-            // TODO: Haven't tested this again since introducing eager serialization.
-            hpp_includes.insert_rerun("compiler_utils.hpp");
-            let gcc_ignore_comment =
-                quote_comment("See: https://github.com/rerun-io/rerun/issues/4027");
-
             methods.push(Method {
                     docs: obj_field.docs.clone().into(),
                     declaration: MethodDeclaration {
@@ -604,8 +599,7 @@ impl QuotedObject {
                     definition_body: quote! {
                         #field_ident = ComponentBatch::from_loggable(#parameter_ident, #descriptor).value_or_throw();
                         #NEWLINE_TOKEN
-                        #gcc_ignore_comment
-                        RR_WITH_MAYBE_UNINITIALIZED_DISABLED(return std::move(*this);)
+                        return std::move(*this);
                     },
                     inline: true,
                 });

diff --git a/rerun_cpp/src/rerun/archetypes/annotation_context.hpp b/rerun_cpp/src/rerun/archetypes/annotation_context.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/arrows2d.hpp b/rerun_cpp/src/rerun/archetypes/arrows2d.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/arrows3d.hpp b/rerun_cpp/src/rerun/archetypes/arrows3d.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/asset3d.hpp b/rerun_cpp/src/rerun/archetypes/asset3d.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/asset_video.hpp b/rerun_cpp/src/rerun/archetypes/asset_video.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/bar_chart.hpp b/rerun_cpp/src/rerun/archetypes/bar_chart.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/boxes2d.hpp b/rerun_cpp/src/rerun/archetypes/boxes2d.hpp