Fix python test for version check. Note on future improved version

rerun-io · Aug 16, 2024 · dfc170b · dfc170b
1 parent 2f3c036
commit dfc170b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/rerun_py/tests/unit/test_version.py b/rerun_py/tests/unit/test_version.py
@@ -14,7 +14,10 @@ def test_version() -> None:
     if ver.prerelease:
         assert ver.prerelease == rr.__version_info__[3]
     else:
-        assert len(rr.__version_info__) == 3
+        # The last field is `None` if there is no prerelease.
+        # TODO(andreas): We released `0.18.0` `"None"` as prerelease, but really it should be `None`.
+        # assert rr.__version_info__[3] is None
+        assert len(rr.__version_info__) == 4
 
     assert rr.__version__ in rr.version()
 

diff --git a/scripts/ci/update_rerun_py_and_c_version.py b/scripts/ci/update_rerun_py_and_c_version.py
@@ -34,6 +34,7 @@ def update_python_line(line: str, version_line: str, version_info_line: str) ->
 def set_rerun_py_version(init_path: Path, version: semver.VersionInfo) -> None:
     version_line = f'__version__ = "{version}"\n'
     version_info_line = (
+        # TODO(andreas): We released `0.18.0` `"None"` as prerelease, but really it should be `None`.
         f'__version_info__ = ({version.major}, {version.minor}, {version.patch}, "{version.prerelease}")\n'
     )