Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityPathFilter variable substitutions are now delegated to (new) ResolvedEntityPathFilter #8543

Merged
merged 6 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/store/re_dataframe/examples/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ fn main() -> anyhow::Result<()> {
let time_to = args.get(4).map_or(TimeInt::MAX, |s| {
TimeInt::new_temporal(s.parse::<i64>().unwrap())
});
let entity_path_filter = EntityPathFilter::try_from(args.get(5).map_or("/**", |s| s.as_str()))?;
let entity_path_filter =
EntityPathFilter::parse_strict(args.get(5).map_or("/**", |s| s.as_str()))?;

// TODO(cmc): We need to take a selector, not a Timeline.
let timeline = match timeline_name {
Expand Down
3 changes: 2 additions & 1 deletion crates/store/re_dataframe/src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,12 @@ impl<E: StorageEngineLike + Clone> QueryEngine<E> {
&self,
filter: &'a EntityPathFilter,
) -> impl Iterator<Item = EntityPath> + 'a {
let filter = filter.clone().resolve_without_substitutions();
self.engine.with(|store, _cache| {
store
.all_entities_sorted()
.into_iter()
.filter(|entity_path| filter.matches(entity_path))
.filter(move |entity_path| filter.matches(entity_path))
})
}
}
3 changes: 2 additions & 1 deletion crates/store/re_dataframe/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ pub use self::external::re_chunk_store::{
};
#[doc(no_inline)]
pub use self::external::re_log_types::{
EntityPath, EntityPathFilter, ResolvedTimeRange, StoreKind, TimeInt, Timeline,
EntityPath, EntityPathFilter, EntityPathSubs, ResolvedEntityPathFilter, ResolvedTimeRange,
StoreKind, TimeInt, Timeline,
};
#[doc(no_inline)]
pub use self::external::re_query::{QueryCache, QueryCacheHandle, StorageEngine};
Expand Down
2 changes: 1 addition & 1 deletion crates/store/re_grpc_client/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ fn activate_catalog_blueprint(
.with_archetype(RowId::new(), timepoint, &vb)
.build()?;

let epf = EntityPathFilter::parse_forgiving("/**", &Default::default());
let epf = EntityPathFilter::parse_forgiving("/**");
let vc = ViewContents::new(epf.iter_expressions());
let view_contents_chunk = ChunkBuilder::new(
ChunkId::new(),
Expand Down
Loading
Loading