Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace --serve with --serve-web from v0.20 #8571

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Replace --serve with --serve-web from v0.20 #8571

merged 4 commits into from
Jan 7, 2025

Conversation

lamteteeow
Copy link
Contributor

@lamteteeow lamteteeow commented Jan 3, 2025 •
edited
Loading

Related

I am not sure why I could not add labels to this PR.

Part of #7766 #7906

What

  • Following the (migration guide to v0.20)[https://rerun.io/docs/reference/migration/migration-0-20] to replace --serve in favor of --serve-web.
  • Added a small warning of deprecation for --serve
  • A quick typo fix: . missing

@lamteteeow
Replace --serve with --serve-web from v0.20
c7f077b 
- Following the (migration guide to v0.20)[https://rerun.io/docs/reference/migration/migration-0-20] to replace `--serve` in favor of `--serve-web`.
- Added a small warning of deprecation for `--serve`
- A quick typo fix: `.` missing
@lamteteeow
Copy link
Contributor Author

lamteteeow commented Jan 3, 2025 •
edited
Loading

I am struggling to add any label to this PR.
They should be include in changelog CLI and 📖 documentation.

@lamteteeow lamteteeow marked this pull request as ready for review January 3, 2025 03:54
Wumpf
Wumpf requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch! We should probably automate this doc file at some point

I am struggling to add any label to this PR.

don't worry, labels can only be added by mantainers.
I'm going with exclude from changelog though since these are just minor bugfixes to the docs

docs/content/reference/cli.md Show resolved Hide resolved
@Wumpf Wumpf added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md CLI Related to the Rerun CLI labels Jan 3, 2025
@lamteteeow lamteteeow requested a review from Wumpf January 4, 2025 07:47
Wumpf
Wumpf approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Wumpf Wumpf merged commit 759a604 into rerun-io:main Jan 7, 2025
5 checks passed
@lamteteeow lamteteeow deleted the patch-1 branch January 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working CLI Related to the Rerun CLI 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamteteeow @Wumpf