Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arrow1 Fields in Archetype::from_arrow #8595

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 6, 2025

Related

What

Port our re_types roundtrip tests from arrow1 to arrow2

@emilk emilk added 🏹 arrow concerning arrow do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 6, 2025
@emilk
Copy link
Member Author

emilk commented Jan 6, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Jan 6, 2025

Copy link

github-actions bot commented Jan 6, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
e5d1182 https://rerun.io/viewer/pr/8595 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk force-pushed the emilk/arrow-deserializer branch from 25ee716 to 77e4543 Compare January 6, 2025 20:57
@emilk
Copy link
Member Author

emilk commented Jan 7, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Jan 7, 2025

crates/store/re_types/tests/types/fuzzy.rs Outdated Show resolved Hide resolved
Base automatically changed from emilk/arrow-deserializer to main January 7, 2025 08:43
@emilk emilk removed the do-not-merge Do not merge this PR label Jan 7, 2025
@emilk emilk force-pushed the emilk/arrow1-architypes branch from 8f0a252 to e5d1182 Compare January 7, 2025 08:44
@emilk emilk merged commit ec9b389 into main Jan 7, 2025
31 checks passed
@emilk emilk deleted the emilk/arrow1-architypes branch January 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants