-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement copy-screenshot-to-clipboard on Web #8607
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that this PR broke meshes in Safari/GL. At least that's what I'm seeing with the web build, which I dont see in other PR.
edit: nvm, it's #8577
edit2: nvm, it's some more downcast typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, but as noted doesn't work on safari
I am guessing safari isn't working because there is a frame-delay between the click and the screenshot being captured, and safari doesn't allow copying unless it in a direct response to a user action… Maybe I'll just remove the button on safari. |
We've had the same problem back then for copying text and eventually solved it. Any chance we can use the same strategy? |
The solution was to run egui on-click, which works if the copy-action then happens on click. In this case, the click results in a deferred screenshot capture that appears next frame, and so Safari says "whoa there, why are you trying to access the clipboard when there was no user action to trigger it?" |
Related